Skip to content

Conversation

@dancer1325
Copy link
Contributor

@dancer1325 dancer1325 commented Nov 1, 2025

Description

  • Fix example wrongly indicated
    • Reason: 🧠example goal is to index documents on different parents, but ONLY 1 is specified🧠

Version

  • ALL

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Example goal is to index documents on different parents, but ONLY 1 is specified

Signed-off-by: dancer13 <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

Thanks, @dancer1325. In the current documentation, no parent 2 exists in the example, so changing parent 1 to parent 2 will lead to errors unless we add parent 2. We have 2 options for the fix here:

  1. Create a complete example with two parents and two children.
  2. Change the comment from "Index two child documents, one for each parent:" to "Index two child documents for the same parent:".

@kolchfa-aws kolchfa-aws added Doc review PR: Doc review in progress backport 3.3 labels Nov 3, 2025
@dancer1325
Copy link
Contributor Author

Thanks, @dancer1325. In the current documentation, no parent 2 exists in the example, so changing parent 1 to parent 2 will lead to errors unless we add parent 2. We have 2 options for the fix here:

  1. Create a complete example with two parents and two children.
  2. Change the comment from "Index two child documents, one for each parent:" to "Index two child documents for the same parent:".

pushed @kolchfa-aws

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @dancer1325!

@kolchfa-aws kolchfa-aws merged commit b3892ca into opensearch-project:main Nov 12, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
* docs: fix mappings field type join example

Example goal is to index documents on different parents, but ONLY 1 is specified

Signed-off-by: dancer13 <[email protected]>

* refactor: address review comments

Signed-off-by: dancer13 <[email protected]>

---------

Signed-off-by: dancer13 <[email protected]>
(cherry picked from commit b3892ca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.3 Doc review PR: Doc review in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants